This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Populate back-compat customized state up front for parity with changesets#127
Merged
Merged
Conversation
|
Changes Unknown when pulling efd1bdf on bugfix/populate-customized-state-early into ** on develop**. |
1 similar comment
|
Changes Unknown when pulling efd1bdf on bugfix/populate-customized-state-early into ** on develop**. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue on 4.6 when back-compat snapshots are enabled where attempting to publish a snapshot from the WP Admin would fail and show an “Unrecognized setting” error shown in the WP Admin screen for the snapshots.
This specific plugin had a
customize_dynamic_setting_argsfilter that would short-circuit if theunsanitized_post_valueslacked a value for the given$setting_id. This is probably a deficiency with the other plugin as I don't see why it would need to do this, but in any case this ensures the plugin works in 4.6 with back compat snapshots as well as in 4.7 with changesets.