Ensure page for posts and page on front are not set to the same page#22
Merged
westonruter merged 3 commits intodevelopfrom Sep 11, 2016
Merged
Conversation
This is to ensure that Customize Posts will have ensured the existence of the static front page section
This ensures that the params can continue to be edited from the control level, without having to wait for the component to be initialized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the UX by eliminating the possibility an error scenario:
Without object selector, a notification should be displayed when these are selected to be the same. Either that, or the
optionelement should be disabled in one or the other if they are regulardropdown-pagescontrols. In any case, the object selector control short-circuits this from even being an issue:In both these cases, the page “Home” is not listed in the selector for Page for Posts because it has already been selected as the Page on Front.
Short demo video: https://youtu.be/lDYN2cWczT8