#1916: Don't try to serialize generic argument types (v2)

bradwilson · bradwilson · commit beab8d96aaea · 2024-06-16T19:09:08.000-07:00
diff --git a/src/common/XunitSerializationInfo.cs b/src/common/XunitSerializationInfo.cs
@@ -166,7 +166,7 @@ internal static bool CanSerializeObject(object value)
 
             Type typeToCheck = valueType;
             if (valueType.IsEnum() || valueType.IsNullableEnum() || (typeToCheck = value as Type) != null)
-                return typeToCheck.IsFromLocalAssembly();
+                return typeToCheck.FullName != null && typeToCheck.IsFromLocalAssembly();
 
             return false;
         }
@@ -463,7 +463,12 @@ public static string Serialize(object value)
 
             var typeData = value as Type;
             if (typeData != null)
+            {
+                if (typeData.FullName == null)
+                    throw new ArgumentException(string.Format(CultureInfo.CurrentCulture, "We don't know how to serialize value typeof({0}) (no full name)", typeData.Name), nameof(value));
+
                 return SerializationHelper.GetTypeNameForSerialization(typeData);
+            }
 
             if (valueType.IsEnum())
                 return SerializeEnum(value, valueType);
diff --git a/test/test.xunit.execution/Common/SerializationHelperTests.cs b/test/test.xunit.execution/Common/SerializationHelperTests.cs
@@ -120,6 +120,23 @@ public void InvalidValue()
             Assert.StartsWith("We don't know how to serialize type System.Object", argEx.Message);
         }
 
+        [Fact]
+        public void CannotSerializeGenericArgumentType()
+        {
+            var type = typeof(ClassWithGenericMethod).GetMethod(nameof(ClassWithGenericMethod.GenericMethod)).GetGenericArguments()[0];
+
+            Assert.False(SerializationHelper.IsSerializable(type));
+            var ex = Record.Exception(() => SerializationHelper.Serialize(type));
+            var argEx = Assert.IsType<ArgumentException>(ex);
+            Assert.Equal("value", argEx.ParamName);
+            Assert.StartsWith("We don't know how to serialize value typeof(U) (no full name)", argEx.Message);
+        }
+
+        class ClassWithGenericMethod
+        {
+            public void GenericMethod<U>() { }
+        }
+
         class MySerializable : IXunitSerializable, IEquatable<MySerializable>
         {
             int value;
