#2922: Remove obsolete AssemblyRunner.Start() overloads (v2)

bradwilson · bradwilson · commit 5fe01ff1dd3c · 2024-06-21T09:33:55.000-07:00
diff --git a/src/xunit.runner.utility/Runners/AssemblyRunner.cs b/src/xunit.runner.utility/Runners/AssemblyRunner.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.ComponentModel;
 using System.Linq;
 using System.Threading;
 using Xunit.Abstractions;
@@ -203,85 +202,15 @@ ITestFrameworkExecutionOptions GetExecutionOptions(bool? diagnosticMessages, boo
             return executionOptions;
         }
 
-        /// <summary>
-        /// Obsolete method. Call the overload with parallelAlgorithm.
-        /// </summary>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        [Obsolete("Please use the overload with startOptions")]
-        public void Start(string typeName = null,
-                          bool? diagnosticMessages = null,
-                          TestMethodDisplay? methodDisplay = null,
-                          TestMethodDisplayOptions? methodDisplayOptions = null,
-                          bool? preEnumerateTheories = null,
-                          bool? parallel = null,
-                          int? maxParallelThreads = null,
-                          bool? internalDiagnosticMessages = null) =>
-            Start(new AssemblyRunnerStartOptions()
-            {
-                DiagnosticMessages = diagnosticMessages,
-                InternalDiagnosticMessages = internalDiagnosticMessages,
-                MaxParallelThreads = maxParallelThreads,
-                MethodDisplay = methodDisplay,
-                MethodDisplayOptions = methodDisplayOptions,
-                Parallel = parallel,
-                PreEnumerateTheories = preEnumerateTheories,
-                TypesToRun = typeName == null ? new string[0] : new string[1] { typeName },
-            });
-
-        /// <summary>
-        /// Starts running tests from a single type (if provided) or the whole assembly (if not). This call returns
-        /// immediately, and status results are dispatched to the events on this class. Callers can check <see cref="Status"/>
-        /// to find out the current status.
-        /// </summary>
-        /// <param name="typeName">The (optional) type name of the single test class to run</param>
-        /// <param name="diagnosticMessages">Set to <c>true</c> to enable diagnostic messages; set to <c>false</c> to disable them.
-        /// By default, uses the value from the assembly configuration file.</param>
-        /// <param name="methodDisplay">Set to choose the default display name style for test methods.
-        /// By default, uses the value from the assembly configuration file. (This parameter is ignored for xUnit.net v1 tests.)</param>
-        /// <param name="methodDisplayOptions">Set to choose the default display name style options for test methods.
-        /// By default, uses the value from the assembly configuration file. (This parameter is ignored for xUnit.net v1 tests.)</param>
-        /// <param name="preEnumerateTheories">Set to <c>true</c> to pre-enumerate individual theory tests; set to <c>false</c> to use
-        /// a single test case for the theory. By default, uses the value from the assembly configuration file. (This parameter is ignored
-        /// for xUnit.net v1 tests.)</param>
-        /// <param name="parallel">Set to <c>true</c> to run test collections in parallel; set to <c>false</c> to run them sequentially.
-        /// By default, uses the value from the assembly configuration file. (This parameter is ignored for xUnit.net v1 tests.)</param>
-        /// <param name="maxParallelThreads">Set to 0 to use unlimited threads; set to any other positive integer to limit to an exact number
-        /// of threads. By default, uses the value from the assembly configuration file. (This parameter is ignored for xUnit.net v1 tests.)</param>
-        /// <param name="internalDiagnosticMessages">Set to <c>true</c> to enable internal diagnostic messages; set to <c>false</c> to disable them.
-        /// By default, uses the value from the assembly configuration file.</param>
-        /// <param name="parallelAlgorithm">The parallel algorithm to be used; defaults to <see cref="ParallelAlgorithm.Conservative"/>.</param>
-        [EditorBrowsable(EditorBrowsableState.Never)]
-        [Obsolete("Please use the overload with startOptions")]
-        public void Start(string typeName = null,
-                          bool? diagnosticMessages = null,
-                          TestMethodDisplay? methodDisplay = null,
-                          TestMethodDisplayOptions? methodDisplayOptions = null,
-                          bool? preEnumerateTheories = null,
-                          bool? parallel = null,
-                          int? maxParallelThreads = null,
-                          bool? internalDiagnosticMessages = null,
-                          ParallelAlgorithm? parallelAlgorithm = null) =>
-            Start(new AssemblyRunnerStartOptions()
-            {
-                DiagnosticMessages = diagnosticMessages,
-                InternalDiagnosticMessages = internalDiagnosticMessages,
-                MaxParallelThreads = maxParallelThreads,
-                MethodDisplay = methodDisplay,
-                MethodDisplayOptions = methodDisplayOptions,
-                Parallel = parallel,
-                ParallelAlgorithm = parallelAlgorithm,
-                PreEnumerateTheories = preEnumerateTheories,
-                TypesToRun = typeName == null ? new string[0] : new string[1] { typeName },
-            });
-
         /// <summary>
         /// Starts running tests. This call returns immediately, and status results are dispatched to the
         /// events on this class. Callers can check <see cref="Status"/> to find out the current status.
         /// </summary>
-        /// <param name="startOptions">The start options. For default values, you may pass
-        /// <see cref="AssemblyRunnerStartOptions.Empty"/>.</param>
-        public void Start(AssemblyRunnerStartOptions startOptions)
+        /// <param name="startOptions">The optional start options.</param>
+        public void Start(AssemblyRunnerStartOptions startOptions = null)
         {
+            startOptions ??= AssemblyRunnerStartOptions.Empty;
+
             lock (statusLock)
             {
                 if (Status != AssemblyRunnerStatus.Idle)
