#1816 Error message doesn't respect -nocolor option (#1824)

eOkadas · bradwilson · commit 5959d748818c · 2018-10-02T08:16:36.000-07:00
setting a NoColoring bool in TransformFactory
if the related CommandLine switch was used.
this commit was amended to fix missing 'static' keyword
diff --git a/src/xunit.console/CommandLine.cs b/src/xunit.console/CommandLine.cs
@@ -170,6 +170,7 @@ protected XunitProject Parse(Predicate<string> fileExists)
                 {
                     GuardNoOptionValue(option);
                     NoColor = true;
+                    TransformFactory.NoErrorColoring = NoColor;
                 }
                 else if (optionName == "noappdomain")    // Here for historical reasons
                 {
diff --git a/src/xunit.console/Utility/TransformFactory.cs b/src/xunit.console/Utility/TransformFactory.cs
@@ -14,6 +14,8 @@ public class TransformFactory
 
         readonly Dictionary<string, Transform> availableTransforms = new Dictionary<string, Transform>(StringComparer.OrdinalIgnoreCase);
 
+        public static bool NoErrorColoring = false;
+        
         protected TransformFactory()
         {
             availableTransforms.Add("xml", new Transform
@@ -65,9 +67,15 @@ static void Handler_DirectWrite(XElement xml, string outputFileName)
         static void Handler_XslTransform(string key, string resourceName, XElement xml, string outputFileName)
         {
 #if NETCOREAPP1_0
-            ConsoleHelper.SetForegroundColor(ConsoleColor.Yellow);
+            if(!NoErrorColoring)
+            {
+                ConsoleHelper.SetForegroundColor(ConsoleColor.Yellow);
+            }
             Console.WriteLine($"Skipping -{key} because XSL-T is not supported on .NET Core 1.x");
-            ConsoleHelper.ResetColor();
+            if(!NoErrorColoring)
+            {
+                ConsoleHelper.ResetColor();
+            }
 #else
             var xmlTransform = new System.Xml.Xsl.XslCompiledTransform();
 

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,7 @@ protected XunitProject Parse(Predicate<string> fileExists)`
`170`	`170`	`{`
`171`	`171`	`GuardNoOptionValue(option);`
`172`	`172`	`NoColor = true;`
	`173`	`+ TransformFactory.NoErrorColoring = NoColor;`
`173`	`174`	`}`
`174`	`175`	`else if (optionName == "noappdomain") // Here for historical reasons`
`175`	`176`	`{`