Merged
Conversation
jerch
reviewed
Jan 21, 2026
Tyriar
approved these changes
Jan 21, 2026
Member
Tyriar
left a comment
There was a problem hiding this comment.
All seems pretty reasonable. Make sure you check the benchmark before and after just to make sure this didn't break perf somehow.
Contributor
Author
|
Performance metrics going from master (uint8) -> this current PR branch (uint16): AI generated Python script to calculate display results in terminal (You probably need to adjust the path if you want to test it on your local machine): |
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #5592
Add registerAPCHandler to parser and expose in API, add test.
This is the first part toward kitty graphics protocol.