Style wide characters at charWidth*2 in DOM#440
Merged
Tyriar merged 6 commits intoxtermjs:masterfrom Jan 9, 2017
Merged
Conversation
Member
|
Note that some half width chars are rendered to wide with some fonts. Also fonts may differ in the wcwidth calculation for some glyphs. Thats the reason why I ended up with a precalculated dictionary of glyph widths for a critial subset of characters. |
This was referenced Jan 3, 2017
Member
Author
|
|
10 tasks
parisk
approved these changes
Jan 8, 2017
Contributor
parisk
left a comment
There was a problem hiding this comment.
Looks great, works great.
LGTM 👍 .
| this.charMeasureElement.classList.add('xterm-char-measure-element'); | ||
| this.charMeasureElement.innerHTML = 'W'; | ||
| this.helperContainer.appendChild(this.charMeasureElement); | ||
| this.charSizeStyleElement = document.createElement('style'); |
Member
Author
|
Tested after merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439
Adds a new util class that encapsulates measuring of characters and restricts it to only be performed during at start up and after a resize (which I think should also be called when char size is changed).
Before:
After:
It appears to work when resizing using crazy sizes too: