Fix for #2488. Use element offsetHeight rather than getBoundingRect#4366
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom Aug 1, 2023
Merged
Fix for #2488. Use element offsetHeight rather than getBoundingRect#4366Tyriar merged 3 commits intoxtermjs:masterfrom
Tyriar merged 3 commits intoxtermjs:masterfrom
Conversation
Tyriar
approved these changes
Aug 1, 2023
Member
Tyriar
left a comment
There was a problem hiding this comment.
Thanks @arekouzounian! Sorry about taking so long for your first ever contributor
Member
|
Eww, looking at this PR again - plz note that Edit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a simple fix for #2488, as using the offsetHeight/Width resolved the issue.
I tried to create a quick test for the patch by having a button that would apply the transform to the body, but applying the transform after the page had loaded didn't cause any issues with character size, even without the patch applied.
I decided just to leave out the button, because it didn't seem to help as a test.
This is my first open-source contribution ever, so any and all feedback is much appreciated. Thank you!