Add support for italic rendering#1422
Merged
Tyriar merged 3 commits intoxtermjs:masterfrom May 1, 2018
Merged
Conversation
2 tasks
Member
|
This is what I see when using Hack under Ubuntu (I have Hack Italic installed):
|
Member
|
I think the problem is the ordering when using
Results in the fallback:
I'll look into fixing this. |
Member
|
Should be fixed now, just needed to rearrange the font attributes. |
Member
|
@bgw FYI I'll merge this in, conflicts should be minimal in your PR |
Tyriar
approved these changes
May 1, 2018
|
|
Member
|
Works for me:
Guessing it's your font config. |
|
@Tyriar Help is appreciated for this Cascadia Code ticket microsoft/cascadia-code#515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for italic rendering.
You can test it with this command:
Let me know if you'd like any changes or anything else!
Related to #580