Allow refresh to execute 30 times a second maximum#128
Merged
parisk merged 1 commit intoxtermjs:masterfrom Jun 14, 2016
Merged
Conversation
For commands that pass a significant amount of output to the write function, this prevents the terminal maxing out the CPU and making the UI unresponsive. While commands can still run beyond what they do on the terminal, it is far better with a debounce in place as every single terminal manipulation does not need to be constructed in the DOM. A side-effect of this is that it makes ^C to interrupt a process seem more responsive. Fixes xtermjs#127 Fixes xtermjs#126
This was referenced Jun 13, 2016
Contributor
|
LGTM. Thanks a lot! |
Contributor
|
@Tyriar I think that there might be a chance that this PR made the focus/blur events go a little bit crazy. Could you please try setting a listener to each event and compare the event emission rate before and after the attached commit? It seems that |
This was referenced Jun 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For commands that pass a significant amount of output to the write function,
this prevents the terminal maxing out the CPU and making the UI unresponsive.
While commands can still run beyond what they do on the terminal, it is far
better with a debounce in place as every single terminal manipulation does not
need to be constructed in the DOM.
A side-effect of this is that it makes ^C to interrupt a process seem more
responsive.
Fixes #127
Fixes #126