Apple iPad - Smart Keyboard Arrows#1064
Closed
exsilium wants to merge 1 commit into
Closed
Conversation
9 tasks
Contributor
Contributor
Author
|
@parisk, thanks, will do! In fact, I did try v3 to begin with, but there seems that there are some interface changes comparing with v2 as it broke my integration with cloud9. I need to look into that first. As for the documentation - I have yet to find the official source. I was looking via console to see what (if any) keydown/keypress event is triggered by the arrows. I also noticed that the key strings passed match with the ones defined in UIKit documentation, except they also define one string for escape key, a key which is lacking on the smart keyboard 😲 (maybe for the future?) For a full event example being sent by the arrows, see this comment |
Contributor
Author
|
I resubmitted this against v3 as #1065 , feel free to close this one, as v2 is feature-locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! It was a pleasant surprise to find out that xterm.js mostly works out of the box with Apple's Smart Keyboard using iPad iOS 11. However, the arrows don't work. Let me know if the main code is not a place for such platform specific mappings. 🍻
keydowneventkeyCode == 0, always.keystrings:UIKeyInputUpArrowUIKeyInputLeftArrowUIKeyInputRightArrowUIKeyInputDownArrowI'm not sure how Android does it and if this is truly iPad specific or not. I'm also not sure if this truly should be part of the main xterm code, or just handled separately via addon/application layer when useragent is identified as iPad.