[XrdOuc] Correct is_subdirectory check for dir with trailing / #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
Nov 12, 2025
9898baa to
6f35c33
Compare
amadio
reviewed
Nov 12, 2025
6f35c33 to
6b2ac04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check fails checks for directories ending with a trailing slash
For e.g.
The current code only takes into account paths without a trailing slash:
subdir[dir.size()]This PR adds checks for paths with a trailing slash:
dir[dir.size()-1]The actual code uses string member functions instead of the array indexing shown above.