Webdav error improvement #2598
Webdav error improvement #2598
Conversation
e88f930 to
5cf2524
Compare
abh3
left a comment
There was a problem hiding this comment.
Just pointed out some not often used syntax in this particular context. Otherwise, I didn't see anything pop out. Of course, we need to find out why all the tests mysteriously failed.
c944a6d to
77ae366
Compare
77ae366 to
ff7e484
Compare
4a8db29 to
b18bfb0
Compare
b18bfb0 to
70c7195
Compare
70c7195 to
7d1ecd6
Compare
dynamic-entropy
left a comment
There was a problem hiding this comment.
I have reverted the use of l.m.n convention in error messages until we reach a consensus and a common document is shared by the WLCG to all storage technologies and clients to agree upon.
7d1ecd6 to
a671a43
Compare
|
Made a logical split between commits as per my understanding and as requested. |
|
This is now much better. I think that after adjusting the tests (x.y.z codes no longer used), and fixing some typos in comments, it will be ready to merge. Thanks a lot! |
a671a43 to
7d2cb57
Compare
7d2cb57 to
6cf94fb
Compare
417e7e4 to
559a20f
Compare
|
@amadio This would be nice to have in For XRootD 6, we can consider going along https://www.rfc-editor.org/rfc/rfc9457.html as per your suggestion, after discussing with the other WLCG communities. Though I doubt we gain much from it other than backing from an RFC thus ending the formatting part of the discussion. |
48e338d to
559a20f
Compare
559a20f to
6318c7b
Compare
We have the following error translation in XrootD XrdErrno <-> errno -> HTTPStatus in xrootd. This is to ensure that we maintain a consistent mapping for err codes from both xrootd and linux to HTTP status codes.
code mapping consistent with current xrootd error code mappings
…ttpReq::reset()` Not resetting it would results in wrong status codes being sent instead of the defaults
- Map XrdErrors to HTTP status codes - Remove old error mapping - Update XrdOssTests to allow mimic failures on read/write independently
6318c7b to
c833dc7
Compare
This PR
As per the plan to add error codes in small instalments, adds tests and mapping for
File not founderrorsAddresses the initial bug reported in [XrdHttp] Return error instead of no reply if xrootd server is readonly #2526 - The server would erroneously skip calling
SendSimpleRespif a valid mapping was missing.Introduces a consistent and exhaustive mapping between
xrderr codestohttp status codesvia a commonerrnotranslation.Proposes a replacement for the existing (initially deemed temporary) switch case mapping to a static table lookup for WebDAV errno mapping.