[Cl] Avoid poller callbacks blocking each other. Fixes #2578 #2582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
Aug 21, 2025
Member
|
How is that? It obviously breaks internal linkage but I could not find any public dependence on ClChannel remaining unchanged. |
c256e6f to
7eac856
Compare
Member
|
@abh3 You are indeed right, the Channel implementation is not exposed, so the change passed the ABI checks. This can safely go into 5.9. |
Contributor
Author
|
I found this still needs some work; I'll have to keep in in draft for a while longer. |
a934415 to
1122d21
Compare
7eac856 to
8c9a2a3
Compare
Member
|
Nevermind, I see this is based on |
8c9a2a3 to
b3b6b66
Compare
Contributor
Author
|
hi @amadio ok, will rebase to master, just a moment. |
b3b6b66 to
ad93707
Compare
Member
|
@smithdh Thank you! Please let me know when you are done, and take the pull request out of draft, so I can include it for 5.9. Cheers, |
ad93707 to
0efe3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.