Couple of Csi bug fixes #2557
Merged
Couple of Csi bug fixes #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@smithdh Due to the compiler warning in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
These are two bug fixs for OssCsi: (as two commits),
(1) Use std::less when comparing two pointers (in this situation the total ordering of pointers is used to give a locking order)
(2) When using nofill option do not cause tag files to potentially be sparse as a side effect.
The first does not appear to cause any problem, using operator<() or std::less produced similar code in the builds I tried. But I believe it's not correct according to the standard. (Actually was previusly using operator<() of a std::shared_ptr, which, may be defined. But commit adds comment as well, to point out ordering issue)
The second may have been seen to cause a rare problem in some old development tests (on rh7) I was reviewing.