Skip to content

Fix memory leak detected by Address sanitizer #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amadio merged 1 commit into from
Jul 1, 2025
Merged

Fix memory leak detected by Address sanitizer #2553

amadio merged 1 commit into from
Jul 1, 2025

Conversation

@dynamic-entropy
Copy link
Collaborator

@dynamic-entropy dynamic-entropy commented Jul 1, 2025 •
edited
Loading

  • buff is duplicated into XrdOucStream and never freed
130: ==77706==ERROR: LeakSanitizer: detected memory leaks 130:
130: Direct leak of 25 byte(s) in 1 object(s) allocated from:
130:     #0 0xffff866de3e0 in strdup (/lib64/libasan.so.8+0xde3e0) (BuildId: 8a06fba3c3703d6d4fc1517732173e023d50b811)
130:     #1 0x40258c in main /xrootd/src/XrdApps/XrdAppsCconfig.cc:189
130:     #2 0xffff85c560d8 in __libc_start_call_main (/lib64/libc.so.6+0x260d8) (BuildId: 6b190cb37e36bb79643c3b0727477dee387d4cf8)
130:     #3 0xffff85c561b8 in __libc_start_main_alias_1 (/lib64/libc.so.6+0x261b8) (BuildId: 6b190cb37e36bb79643c3b0727477dee387d4cf8)
130:     #4 0x402d6c in _start (/home/xrootd/build/bin/cconfig+0x402d6c) (BuildId: abdf333ad86ac01dbfaab35089b0f2ca46c00ff1)

@dynamic-entropy dynamic-entropy requested a review from amadio July 1, 2025 08:25
amadio
amadio reviewed Jul 1, 2025
View reviewed changes
@amadio amadio added this to the 5.8.4 milestone Jul 1, 2025
@amadio
Copy link
Member

amadio commented Jul 1, 2025

As commented on Mattermost, please drop the #0, #1, etc from your stack trace if you want to keep it. Otherwise GitHub will treat that as mentions to the issues 1, ... and create comments there as well, which is not ideal.

@dynamic-entropy
Fix memory leak detected by Address sanitizer
723e71f 
- buff is duplicated into XrdOucStream and never freed

==77706==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 25 byte(s) in 1 object(s) allocated from:
    0 0xffff866de3e0 in strdup (/lib64/libasan.so.8+0xde3e0) (BuildId: 8a06fba3c3703d6d4fc1517732173e023d50b811)
    1 0x40258c in main /xrootd/src/XrdApps/XrdAppsCconfig.cc:189
    2 0xffff85c560d8 in __libc_start_call_main (/lib64/libc.so.6+0x260d8) (BuildId: 6b190cb37e36bb79643c3b0727477dee387d4cf8)
    3 0xffff85c561b8 in __libc_start_main_alias_1 (/lib64/libc.so.6+0x261b8) (BuildId: 6b190cb37e36bb79643c3b0727477dee387d4cf8)
    4 0x402d6c in _start (/home/xrootd/build/bin/cconfig+0x402d6c) (BuildId: abdf333ad86ac01dbfaab35089b0f2ca46c00ff1)
@dynamic-entropy
Copy link
Collaborator Author

dynamic-entropy commented Jul 1, 2025

Dropped the #x from the commit message 👍 Didn't realise it before.
Rebased on the current master.

@amadio
Copy link
Member

amadio commented Jul 1, 2025

Looks good now, thanks!

@amadio amadio merged commit f358988 into xrootd:master Jul 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amadio amadio amadio left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.8.4

Development

Successfully merging this pull request may close these issues.

2 participants

@dynamic-entropy @amadio