-
Notifications
You must be signed in to change notification settings - Fork 166
[Ssi] Track SsiFileReq use to avoid use after free #2479 #2481 #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@iagaponenko It would be great if you could run your tests with the commit from this pull request to confirm that it fixes the issues you reported. We unfortunately do not have Ssi covered yet as part of our test suite. Thank you! |
|
@amadio Thank you for the fix! I'm a bit busy for the most part of this week. Preliminarily, I will have time to resume my stress testing of Qserv (and SSI) this Friday. |
|
@iagaponenko No problem, 5.9 is planned to be released towards the end of Summer (i.e. just ahead of the upcoming FTS/XRootD workshop), so there's plenty of time. BTW, you should consider participating in the workshop, present about how you are using XRootD, qserv seems like a very interesting concept. Cheers, |
|
Here is what I'm going to try now |
|
Likely so. As far as I can see, the changes are limited to XrdSsi so the pull should apply cleanly to devel or master. (it's target to devel at the moment). Let us know how it went. |
|
This is an update. I've been stress-testing the PR for 18 hours using the 14-worker Qserv that we have at SLAC. No crashes, memory leaks, or other problems have been seen so far at the Qserv workers (SSI servers). I will let the tests run for at least another 6 hours. |
|
@iagaponenko Thank you for testing and confirming that this fixes the issue. This is scheduled for XRootD 5.9.0, which will be released towards the end of Summer. |
|
@smithdh Could you please move this out of draft when you are ready? Thank you! |
|
This can be merged as it has already gone through testing by the original problem submitter and has been signed off. |
|
Hi @abh3, yes, I will soon start processing patches for XRootD 5.9.0 and this will certainly get merged for the release, which is targeted for the end of this month. |
6e373a9 to
354ea75
Compare
Initial (rather large) patch aiming to fix #2479, #2481 considered to be due to use of XrdSsiFileReq after free/recycle; typically triggered when client is canceling requests.