Skip to content

Conversation

@smithdh
Copy link
Contributor

@smithdh smithdh commented Jun 2, 2025

Initial (rather large) patch aiming to fix #2479, #2481 considered to be due to use of XrdSsiFileReq after free/recycle; typically triggered when client is canceling requests.

@amadio
Copy link
Member

amadio commented Jun 2, 2025

@iagaponenko It would be great if you could run your tests with the commit from this pull request to confirm that it fixes the issues you reported. We unfortunately do not have Ssi covered yet as part of our test suite. Thank you!

@amadio amadio added this to the 5.9.0 milestone Jun 2, 2025
@iagaponenko
Copy link

@amadio Thank you for the fix! I'm a bit busy for the most part of this week. Preliminarily, I will have time to resume my stress testing of Qserv (and SSI) this Friday.

@amadio
Copy link
Member

amadio commented Jun 2, 2025

@iagaponenko No problem, 5.9 is planned to be released towards the end of Summer (i.e. just ahead of the upcoming FTS/XRootD workshop), so there's plenty of time. BTW, you should consider participating in the workshop, present about how you are using XRootD, qserv seems like a very interesting concept. Cheers,

@iagaponenko
Copy link

@amadio @abh3 I have tried to add this commit on top of XTOOTD v5.6.2 that we use in Qserv. Unfortunately, the compilation fails. Should I try using this PR instead?

@iagaponenko
Copy link

Here is what I'm going to try now

 git clone git@github.com:xrootd/xrootd.git
 cd xrootd
 git fetch origin pull/2523/head:test-branch
 git checkout test-branch
...

@abh3
Copy link
Member

abh3 commented Jun 19, 2025

Likely so. As far as I can see, the changes are limited to XrdSsi so the pull should apply cleanly to devel or master. (it's target to devel at the moment). Let us know how it went.

@iagaponenko
Copy link

@abh3 @amadio I have built Qserv based on the PR. The basic integration tests (of Qserv) have passed. I have started stress tests of the large (14 worker nodes) Qserv at USDF. I'm planning to run the tests for at least 24 hours. I will keep you posted on progress.

@iagaponenko
Copy link

iagaponenko commented Jun 20, 2025

This is an update. I've been stress-testing the PR for 18 hours using the 14-worker Qserv that we have at SLAC. No crashes, memory leaks, or other problems have been seen so far at the Qserv workers (SSI servers). I will let the tests run for at least another 6 hours.

@iagaponenko
Copy link

@amadio @abh3 I have not seen any crashes with this PR after 26+ hours of stress tests. I think this PR is good from my poingt of veiw. @abh3 I will also need a stable version of XROOTD/SSI that will include the PR after it's merged. I need this for building Qserv. Thank you!

@amadio
Copy link
Member

amadio commented Jun 21, 2025

@iagaponenko Thank you for testing and confirming that this fixes the issue. This is scheduled for XRootD 5.9.0, which will be released towards the end of Summer.

@amadio
Copy link
Member

amadio commented Jun 23, 2025

@smithdh Could you please move this out of draft when you are ready? Thank you!

@amadio amadio changed the base branch from devel to master August 12, 2025 09:53
@amadio amadio moved this to Ready in Release Planning Aug 12, 2025
@amadio amadio marked this pull request as ready for review August 12, 2025 09:54
@abh3
Copy link
Member

abh3 commented Sep 3, 2025

This can be merged as it has already gone through testing by the original problem submitter and has been signed off.

@amadio
Copy link
Member

amadio commented Sep 3, 2025

Hi @abh3, yes, I will soon start processing patches for XRootD 5.9.0 and this will certainly get merged for the release, which is targeted for the end of this month.

@amadio amadio merged commit bc4f464 into xrootd:master Sep 8, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Done in Release Planning Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

4 participants