Skip to content

Conversation

@smithdh
Copy link
Contributor

@smithdh smithdh commented May 20, 2025

Fixes lost response when an error occurs before the resend of a requeued request. e.g. a requeued message can happen when the client has been redirected or told to wait and resend a request later by kxr_wait. An error before resend could be that the stream connect is lost or the request times out before the resend. Introduced in #2365.

@amadio amadio added this to the 5.8.3 milestone May 20, 2025
@amadio
Copy link
Member

amadio commented May 20, 2025

@smithdh Normally, I add a Fixes: commithash when a commit fixes another one, maybe you could add it too in your commit message (same for the description in the pull request, it would be nice to add it to the commit). Example: b0e427b. Thank you!

@smithdh smithdh changed the title [Cl] Reset state when resending a message [Cl] Reset state when resending a message. Fixes: 3a957083 May 20, 2025
@smithdh smithdh force-pushed the ds_xrdcl_pendingstate branch 2 times, most recently from 17b2777 to 66fdafa Compare May 21, 2025 08:08
Fixes lost response when an error occurs before the resend
of a requeued request. e.g. a requeued message can happen when
the client has been redirected or told to wait and resend a
request later by kxr_wait. An error before resend could be that
the stream connect is lost or the request times-out before resend.
@smithdh smithdh force-pushed the ds_xrdcl_pendingstate branch from 66fdafa to 679f319 Compare May 21, 2025 09:06
@amadio
Copy link
Member

amadio commented May 21, 2025

@smithdh 👍 Thanks for the updated commit message. Please put out of draft when you feel it's ready.

@smithdh smithdh marked this pull request as ready for review May 21, 2025 11:57
@amadio amadio moved this to Backlog in Release Planning May 21, 2025
@amadio amadio moved this from Backlog to In review in Release Planning May 21, 2025
@amadio amadio merged commit dc26105 into xrootd:devel May 22, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Release Planning May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants