Fix broken file access mode detection #2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The access mode values for files are not the same for all platforms. The detection of a read only request here assumes that O_RDONLY is 0, which is not mandated by the POSIX standaed. Linux: #define O_ACCMODE 00000003 #define O_RDONLY 00000000 #define O_WRONLY 00000001 #define O_RDWR 00000002 But this is also allowed: #define O_RDONLY 0x0001 /* Open read-only. */ #define O_WRONLY 0x0002 /* Open write-only. */ #define O_RDWR (O_RDONLY|O_WRONLY) /* Open for reading and writing. */ #define O_ACCMODE O_RDWR /* Mask for file access modes. */ And on systems using this option the detection of a read only request as implemented here is is broken and the cache test fails. This commit fixes the detection so that it is done in the intended way that works everywhere.
Member
|
Nice to see new tests at work. Thank you for the fix! |
osschar
approved these changes
May 15, 2025
Contributor
osschar
left a comment
There was a problem hiding this comment.
Thank you for fixing this! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The access mode values for files are not the same for all platforms. The detection of a read only request here assumes that O_RDONLY is 0, which is not mandated by the POSIX standaed.
Linux:
But this is also allowed:
And on systems using this option the detection of a read only request as implemented here is is broken and the cache test fails.
This commit fixes the detection so that it is done in the intended way that works everywhere.
Compare:
xrootd/src/XrdCeph/XrdCephPosix.cc
Line 683 in fde6e45
xrootd/src/XrdOssCsi/XrdOssCsiFile.cc
Line 315 in fde6e45
Log of failing test:
cachelog.txt