[XrdPosix] Map operation timeouts to ETIME #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elsewhere, we use ETIME to indicate a server timeout (particularly, XRootD uses it for "504 Gateway Timeout"). Many users have found it confusing that timeouts result in "stale NFS file handle". Beyond giving the correct HTTP status code, this will cause the following message to be provided: ``` sTREAM ioctl timeout ``` It's not the greatest -- and the capitalization is strange -- but at least it includes the word "timeout". For the xroot protocol, one receives 3035, `kXR_TimerExpired`.
Member
|
Looks good to me, let's hear from @abh3 before merging, though, since you asked for his review as well. |
Collaborator
Author
|
Yup! Mostly wrote this down as a discussion point... if we agree it's an improvement, the patch itself is obviously trivial. |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elsewhere, we use ETIME to indicate a server timeout (particularly, XRootD uses it for "504 Gateway Timeout"). Many users have found it confusing that timeouts result in "stale NFS file handle". Beyond giving the correct HTTP status code, this will cause the following message to be provided:
It's not the greatest -- and the capitalization is strange -- but at least it includes the word "timeout". For the xroot protocol, one receives 3035,
kXR_TimerExpired.