[XrdPfc] Add simple integration test for the PFC #2477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
Apr 11, 2025
amadio
reviewed
Apr 11, 2025
This adds a simple integration test that downloads a file from a XCache server through another fixture as an origin, then verifies the file is unchanged.
Member
|
This test is failing on my machine as follows: |
Member
|
There seems to be a race condition between the host and cache test setups. I will fix. |
Collaborator
Author
|
@amadio - indeed, it looks like the setup.sh script does not verify that XRootD is functioning and listening on a port before proceeding. I'm surprised this doesn't lead to other failures? This is the (ugly) shell code I use to force my unit tests to pause until XRootD is ready: If you know of better ways, I'll be quite interested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple integration test that downloads a file from a XCache server through another fixture as an origin, then verifies the file is unchanged.
@amadio - the approach is as what we discussed earlier today ... added explicit dependency between fixtures but did not rework how the CMakeLists.txt is working.