[XrdTpc] Force use of Expect: 100-continue header
#2475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
Apr 9, 2025
Contributor
|
Thanks for the fix @bbockelm , I did not manage to see how you get the value The only place where m_content_length is set is in Maybe I missed something though ;) Thanks |
On older versions of libcurl (at least 7.x), PUTs unconditionally triggered the use of `Expect: 100-continue`. We've observed that newer versions of libcurl no longer force this behavior -- but also have bugs when it's not present! Upstream issue is reported at curl/curl#17004. Pragmatically, until libcurl is fixed -- and we can assume the fix is deployed everywhere -- we will need to go back to the older behavior as seen on AlmaLinux 9 and similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older versions of libcurl (at least 7.x), PUTs unconditionally triggered the use of
Expect: 100-continue.We've observed that newer versions of libcurl no longer force this behavior -- but also have bugs when it's not present! Upstream issue is reported at curl/curl#17004.
Pragmatically, until libcurl is fixed -- and we can assume the fix is deployed everywhere -- we will need to go back to the older behavior as seen on AlmaLinux 9 and similar.
Credit to @dynamic-entropy for uncovering the issue, narrowing it down, and coming up with the approach for the fix. I just added some comments :)
Fixes: #2470