[XrdHttp] Quote the resource when handling a redirect #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any chance we could have a test added for this? |
Contributor
Author
|
Sure, I will push something for this. |
The resource string is unquoted when the request is handled but in case of a redirect the resource should be quoted again otherwise the client will be redirected with a different path than the initial one.
f2dc469 to
a8eb442
Compare
Member
|
Look in |
Contributor
Author
|
Just a few extra remarks related to this pull request:
|
Member
|
Something that was added doesn't work as expected: https://my.cdash.org/tests/253509135 |
Contributor
Author
|
Yes, curl was missing from the Alpine image. |
amadio
reviewed
Feb 13, 2025
7d95fca to
1d33347
Compare
that are accessed both via HTTP and XRootD. Extend the cluster tests configuration by enabling HTTP support and exercise uploads, downloads also via HTTP protocol for data that is distributed in the cluster. The main target of the new tests is to ensure the proper unquoting and quoting functionality in the XrdHttp layer.
1d33347 to
efc54b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource string is unquoted when the request is handled but in case of a redirect the resource should be quoted again otherwise the client will be redirected with a different path than the initial one.