[XrdHttp] Add trailing slash to directories in listing #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache, when generating a HTML listing of a local directory, will suffix directory names with a trailing slash. This PR tweaks the XRootD directory listing to do the same and adds a corresponding integration test. Beyond matching common practice, the HTTP fsspec plugin in the Python ecosystem uses the trailing slash as a heuristic to indicate a directory. With this change, Python users should be able to recursively list directories in XRootD. While not strictly required, this makes a significant improvement for the lives of Python users.
ccaffy
approved these changes
Feb 13, 2025
Contributor
ccaffy
left a comment
There was a problem hiding this comment.
Looks good to me, thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache, when generating a HTML listing of a local directory, will suffix directory names with a trailing slash. This PR tweaks the XRootD directory listing to do the same and adds a corresponding integration test.
Beyond matching common practice, the HTTP fsspec plugin in the Python ecosystem uses the trailing slash as a heuristic to indicate a directory. With this change, Python users should be able to recursively list directories in XRootD. While not strictly required, this makes a significant improvement for the lives of Python users.