[Cl] Also recognise IPv4 mapped addresses #2422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will remove time_t commit from this pr, and move out this PR out of draft (for review etc) when time_t changes on devel. |
Contributor
Author
|
I removed the time_t related change (and rebased), and made a small change to the patch. I'll move the patch out of draft; although I see that we've removed the compatability->mapped change from the devel branch, so inface the original reason for this patch has gone. Perhaps we want to abandon this patch. |
Member
|
Not at all, this patch has value. We removed he offending patch because we needed to get the CI moving as it was holding up a lot of stuff. We need to review what the appropriate change is here. The removal of compatible IP addresses is not time driven but was to address long term trends. |
e9dc92a to
c958645
Compare
Member
|
This is destined for 5.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft, aiming to fix some test failures, usually on alpine and mac os.