-
Notifications
You must be signed in to change notification settings - Fork 166
Fix format errors found by the compiler #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map various connection-related errors in XrdCl in XCache all the
way through to the HTTP layer.
This allows a failure to connect to the origin to be represented
with the correct status code ("Bad Gateway"); currently, a down
origin results in a 500 ("Internal Server Error") which is misleading
for users.
uint16_t to time_t. Since time_t can be 64 bits the Python bindings need to use unsigned long long.
We test for overflow, but now timeouts use time_t, which may be 64 bits wide, so use 2^65 to force an overflow in that case too.
Reverts commit eb4295e as the hack introduced there is no longer needed after the current fix. Fixes: xrootd#2357
In the new SciTag specification, the content of the emitted firefly should always be created from the data sender point of view. For HTTP PUT: the srcIp is the client, dstIP is the server, sentBytes=socketReceivedBytes (~=fileSize), receivedBytes=socketSentBytes (~=0) For HTTP GET: the srcIP is the server, dstIP is the client, sentBytes=socketSentBytes(~=fileSize) receivedBytes=socketReceivedBytes(~=0) The distinction is therefore done via the pmark.appname CGI that is equal to "http-get" if the client request is a GET request or equal to "http-put" if not.
While RFC 4291 in 2006 introduced "IPv4-compatible IPv6 addresses" (i.e. ::<ipv4>) if also specified IPv4 mapped addresses (i.e. ::ffff:<ipv4>). In the intervening years, most implementation no longer support compatible addresses and mapped address format has replaced it. This update removes support for compatible address format generation as it's unlikely to work and substitutes mapped address format as the alternative.
Additional fixes related to the use time_t for timeouts change
945ec35 to
dbf7e44
Compare
14432e7 to
653bf57
Compare
Contributor
Author
Member
|
@ellert Apologies, I didn't realize that this and the other were the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fixes related to the use time_t for timeouts change
The PR was split out from #2380. The commit in this PR is related to the change of type for timeouts to time_t that is only in the devel branch. It was split out to a separate PR in order to rebase the original PS to masterl