Skip to content

Correct forward declaration of XrdSfsFSctl #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amadio merged 1 commit into from
Jan 27, 2025
Merged

Correct forward declaration of XrdSfsFSctl #2405

amadio merged 1 commit into from
Jan 27, 2025

Conversation

@bbockelm
Copy link
Collaborator

@bbockelm bbockelm commented Jan 14, 2025

Withouth this correction, -Wall -Werror builds on Mac fail when importing the headers with the following message:

/xrootd/build/release_dir/include/xrootd/XrdSfs/XrdSfsInterface.hh:161:1: error: 'XrdSfsFSctl' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
struct XrdSfsFSctl //!< SFS_FSCTL_PLUGIN/PLUGIO/PLUGXC parms
^
/xrootd/build/release_dir/include/xrootd/XrdOfs/XrdOfsFSctl_PI.hh:44:1: note: did you mean struct here?

I think aligning the actual declaration and the forward declaration is a reasonable thing to do here.

@abh3 abh3 self-requested a review January 16, 2025 05:40
@abh3
Copy link
Member

abh3 commented Jan 16, 2025

I approve of this pull request but why did alpine and coverage fail as this is a trivial one? Aberation?

abh3
abh3 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@abh3 abh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, thanks Brian.

@amadio
Copy link
Member

amadio commented Jan 16, 2025

The coverage build moved automatically to Ubuntu 24.04 (it's using the ubuntu-latest runner), where there's a minor issue in the coverage generation of XrdOucJson.hh. I am moving it back to Ubuntu 22.04 while I sort that out. The Alpine and macOS builds fail because of 7731531 and d54785d (causes "Invalid Address" errors). I suspect this is a problem in the client that needs further changes to get fixed.

@amadio
Copy link
Member

amadio commented Jan 16, 2025

@abh3 See here a more verbose log which shows a failure on macOS 14. I think we internally have something in the client changing 127.0.0.1 to [::ffff:127.0.0.1], which may be the underlying reason for the failures in devel and on macOS (as the network setup for IPv6 is kinda broken there, but also this reminds me of #1779).

@bbockelm
Correct forward declaration of XrdSfsFSctl
fdbecc0 
Withouth this correction, `-Wall -Werror` builds on Mac fail when
importing the headers with the following message:

```
/xrootd/build/release_dir/include/xrootd/XrdSfs/XrdSfsInterface.hh:161:1: error: 'XrdSfsFSctl' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
struct XrdSfsFSctl //!< SFS_FSCTL_PLUGIN/PLUGIO/PLUGXC parms
^
/xrootd/build/release_dir/include/xrootd/XrdOfs/XrdOfsFSctl_PI.hh:44:1: note: did you mean struct here?
```
@bbockelm bbockelm force-pushed the fsctl_class_mismatch branch from aa701fb to fdbecc0 Compare January 27, 2025 14:17
@bbockelm bbockelm changed the base branch from devel to master January 27, 2025 14:17
@amadio amadio merged commit b4d9949 into xrootd:master Jan 27, 2025
9 checks passed
@amadio amadio added this to the 5.7.3 milestone Jan 27, 2025
@bbockelm bbockelm mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abh3 abh3 abh3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.7.3

Development

Successfully merging this pull request may close these issues.

3 participants

@bbockelm @abh3 @amadio