[XrdHttp] Set oss.asize if object size is known #2378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf0b7bc to
d54785d
Compare
662bf8d to
c5a25dc
Compare
Collaborator
Author
|
Per input from @amadio in a different ticket, I re-targeted this to master. |
Collaborator
Author
|
@ccaffy - since you've been working on the XrdHttp pieces, would you be able to review this? |
ccaffy
requested changes
Jan 13, 2025
Contributor
ccaffy
left a comment
There was a problem hiding this comment.
Thanks Brian, I tried it on my local box, it works without any problem. Just one minor thing to change if possible :)
e13461e to
7241378
Compare
ccaffy
approved these changes
Jan 16, 2025
Contributor
ccaffy
left a comment
There was a problem hiding this comment.
That's great, thanks for the addition of the system tests!
If the client declares the expected size of the uploaded object, then pass this information on to the OSS layer via the `oss.asize` CGI. This is relevant for the S3 backend as the S3 protocol requires object sizes to be declared ahead of time. If XRootD doesn't provide this information, then the S3 OSS backend has to buffer the uploaded object to know the final size, costing both in overall throughput and memory usage.
This adds a test where `curl` is invoked in such a way that the final object length is known at open time. This is passed through to the xrootd bridge layer and allows the OSS to allocate itself appropriately. The test itself looks through the server log not for the oss.asize string (which is not logged) but rather for the length of the request (which contains the URL) sent to the bridge. The first upload of a file does not include `oss.asize` so the size of the two log messages can be compared.
7241378 to
368047c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client declares the expected size of the uploaded object, then pass this information on to the OSS layer via the
oss.asizeCGI.This is relevant for the S3 backend as the S3 protocol requires object sizes to be declared ahead of time. If XRootD doesn't provide this information, then the S3 OSS backend has to buffer the uploaded object to know the final size, costing both in overall throughput and memory usage.