Skip to content

Conversation

@ellert
Copy link
Contributor

@ellert ellert commented Nov 11, 2024

@amadio amadio force-pushed the devel branch 2 times, most recently from d340f82 to 5810395 Compare November 25, 2024 10:17
@amadio amadio force-pushed the devel branch 2 times, most recently from d372ef5 to 116d1e6 Compare November 26, 2024 15:41
@amadio
Copy link
Member

amadio commented Nov 26, 2024

Hi @ellert, please rebase rather than merge. That way only your commits will show up. However, I think the current way you are handling the definitions is not optimal. We need to modernize the CMake to be target-based, and get the required flags via the INTERFACE_COMPILE_OPTIONS property from the targets, by using target_compile_options(...) then installing the targets. This needs a major refactoring of parts of the build system, so I my plan is to work on it for v6.0 next year. We can have a stopgap solution in between, but we need to ensure that the build system and XRootDConfig.cmake do not get out of sync, which the current patch doesn't do. Cheers,

@ellert ellert force-pushed the cmake-definitions branch from 413976f to 77298dd Compare January 22, 2025 18:57
@ellert ellert changed the base branch from devel to master January 22, 2025 18:57
@amadio amadio merged commit df5006c into xrootd:master Feb 13, 2025
9 checks passed
@amadio amadio added this to the 5.8.0 milestone Feb 13, 2025
@ellert ellert deleted the cmake-definitions branch February 13, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants