Skip to content

[XrdCl] Fix hidden overloaded virtual compilation error #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amadio merged 1 commit into from
Jul 26, 2024
Merged

[XrdCl] Fix hidden overloaded virtual compilation error #2291

amadio merged 1 commit into from
Jul 26, 2024

Conversation

@ellert
Copy link
Contributor

@ellert ellert commented Jul 4, 2024 

/builddir/build/BUILD/xrootd-5.7.0/src/XrdCl/XrdClClassicCopyJob.cc:722:35: error: ‘virtual XrdCl::XRootDStatus {anonymous}::XRootDSource::GetXAttr(std::vector<std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)’ was hidden [-Werror=overloaded-virtual=]
  722 |       virtual XrdCl::XRootDStatus GetXAttr( std::vector<XrdCl::xattr_t> &xattrs )
      |                                   ^~~~~~~~
/builddir/build/BUILD/xrootd-5.7.0/src/XrdCl/XrdClClassicCopyJob.cc:1153:35: note:   by ‘virtual XrdCl::XRootDStatus {anonymous}::XRootDSourceZip::GetXAttr(std::vector<XrdCl::XAttr>&)’
 1153 |       virtual XrdCl::XRootDStatus GetXAttr( std::vector<XrdCl::XAttr> &xattrs )
      |                                   ^~~~~~~~

@amadio
Copy link
Member

amadio commented Jul 4, 2024

@ellert What distro/compiler was this? I'd like to add to CI, I guess it could be latest Fedora (GCC 15, maybe?).

@ellert
Copy link
Contributor Author

ellert commented Jul 4, 2024 •
edited
Loading

What distro/compiler was this?

Fedora 40 and 41 with gcc 14.1.1. But the error is only reported on s390x for some reason.
See: https://koji.fedoraproject.org/koji/taskinfo?taskID=119971890

@ellert @amadio
[XrdCl] Fix hidden overloaded virtual compilation error
b69ee8f 
/builddir/build/BUILD/xrootd-5.7.0/src/XrdCl/XrdClClassicCopyJob.cc:722:35: error: ‘virtual XrdCl::XRootDStatus {anonymous}::XRootDSource::GetXAttr(std::vector<std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)’ was hidden [-Werror=overloaded-virtual=]
  722 |       virtual XrdCl::XRootDStatus GetXAttr( std::vector<XrdCl::xattr_t> &xattrs )
      |                                   ^~~~~~~~
/builddir/build/BUILD/xrootd-5.7.0/src/XrdCl/XrdClClassicCopyJob.cc:1153:35: note:   by ‘virtual XrdCl::XRootDStatus {anonymous}::XRootDSourceZip::GetXAttr(std::vector<XrdCl::XAttr>&)’
 1153 |       virtual XrdCl::XRootDStatus GetXAttr( std::vector<XrdCl::XAttr> &xattrs )
      |                                   ^~~~~~~~
@amadio amadio merged commit 1fd9504 into xrootd:devel Jul 26, 2024
@amadio
Copy link
Member

amadio commented Jul 26, 2024

Thanks!

@amadio amadio added this to the 5.7.1 milestone Jul 26, 2024
@ellert ellert deleted the hidden-virtual branch July 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@ellert @amadio