Merged
Conversation
Collaborator
|
hello! please provide new test 'authentication credentials' from firebase to test your changes. |
Owner
|
@luckykumarirai thanks for the PR! I have tested that while creating new links its easy to generate random characters, however I am unable to change the same when editing the links already created. Please fix. |
xprilion
requested changes
Dec 23, 2020
Owner
xprilion
left a comment
There was a problem hiding this comment.
Fix generating random characters when editing links
Contributor
Author
|
Now I have fixed generating random characters when editing links problem. |
xprilion
approved these changes
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Every time needs to enter a custom URL.
What is the new behavior?
Whenever we do not want to enter a custom URL by click on the button auto-generate 5-10 character code as a custom URL.
if we think need to give our own custom URL then we can enter both functionality present.
Review link:
https://fireshort-e4651.web.app/admin
email:- shorturl@gmail.com
Password:- Url@123
close #5