CacheHandler::isValid() 에서 $modified_time 기본값이 없는 문제 수정#2205
Merged
1 commit merged intoJan 9, 2018
Merged
Conversation
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CacheBase를 포함한 실제 캐시 클래스는 모두 isValid() 메소드에 $modified_time = 0 으로 기본값이 지정되어 있는데, CacheHandler 클래스에만 기본값이 없습니다.
이것 때문에 일부 서드파티 자료를 PHP 7.1에서 실행하면 Too few arguments to function CacheHandler::isValid(), 1 passed ... and exactly 2 expected 라는 에러가 발생하고 있습니다. 개발자 입장에서도 두 번째 인자가 필요한지 안 필요한지 헷갈리니까요.
일관성있는 기본값을 지정하여 에러를 방지합니다.