존재하지 않는 문서가 있을경우 캐싱을 하지 않도록 함#2196
Merged
1 commit merged intoJan 2, 2018
Merged
Conversation
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rhymix/rhymix@92d8f17
서드파티에서 insertDocument 실행 이후 after트리거에서 documentModel::getDocument 를 실행할경우 document 값이 모두 비어있는 값으로 리턴되는 부분을 찾았습니다.
그래서 찾아본 원인이 board.Controller.php 에서 해당 게시글이 있는지 없는지를 검사하는 과정에서
https://github.com/xpressengine/xe-core/blob/master/modules/board/board.controller.php#L74
를 실행하고 있었으며, 해당 액션으로 인해 미리 빈값이 캐싱이 되어버렸습니다.
여기에 document 문서가 존재하지 않을경우 캐싱을 하지 않도록 하는 PR입니다.
이는 기진님께서 패치에 도움주셨으며, 전적으로 GPL v2, LGPL v2 듀얼라이선스를 책택하여 XE에서 적용할 수 있는 라이선스 코드입니다.
리뷰해주셔서 감사합니다 :)