첨부 파일 본문 삽입 시 외부 URL을 포함할 수 있도록 개선#1980
Merged
2 commits merged intoFeb 22, 2017
Merged
Conversation
Develop #161019
YJSoft
approved these changes
Oct 31, 2016
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ckeditor 에서 파일첨부 후 '본문삽입'을 클릭하면 ( insertToContent )
파일이 업로드 되었던 uploaded_filename 앞에 강제로 window.request_uri ( 도메인 ) 이 붙어서 들어간다
문제는 uploaded_filename 자체가 도메인을 포함하고 있는 경우
( 예를들면 파일서버를 분리해서, 외부서버의 파일주소를 uploaded_filename 이 다 포함하고 있는 경우 )
강제로 붙는 window.request_uri 때문에 http:// 가 두번 나오는 이상한 주소가 강제로 만들어진다
따라서 insertToContent 시, uploaded_filename 에 http:// 또는 https:// 가 있는지 검토해서
없을땐 window.request_uri 를 붙이고, 있을땐 안 붙이게 개선을 했다
파일첨부시, 파일을 외부의 서버로 보내는 기능을 구현하려다보니, 본문추가 기능을 유지하기 위해서 개선