Skip to content

Fix @$() subprocess operator#3510

Closed
laloch wants to merge 5 commits into
xonsh:masterfrom
laloch:fix-captured-inject
Closed

Fix @$() subprocess operator#3510
laloch wants to merge 5 commits into
xonsh:masterfrom
laloch:fix-captured-inject

Conversation

@laloch

@laloch laloch commented Apr 8, 2020

Copy link
Copy Markdown
Member

See the trail in #3156.

Closes #2328
Closes #2755
Closes #3457

@gforsyth

gforsyth commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

Hey @laloch -- I set up the github actions to only trigger on push for a reason I can't remember, I think that's why they aren't triggering. You can either push up an empty commit, or we can try to add PRs to the list of trigger actions

@laloch

laloch commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

I can try again, I did several pushes the last time and it didn't trigger the CI anyway.

@laloch

laloch commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

You see? No CI for me 😞

@scopatz

scopatz commented Apr 8, 2020

Copy link
Copy Markdown
Member

Let's just get this merged. I wonder @gforsyth if this is related to the fact that @laloch id pushing from a fork

@gforsyth

gforsyth commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

It shouldn't, but I'll see if we need to add anything else to the config

@laloch

laloch commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

It's no problem for me to keep testing.

@scopatz

scopatz commented Apr 8, 2020

Copy link
Copy Markdown
Member

Yeah, but I want to cut a release today, and don't want to mix these two issues 😉

@laloch

laloch commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

So, now with #3511 merged in, should I try one last time and rebase to master?

@gforsyth

gforsyth commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

So, now with #3511 merged in, should I try one last time and rebase to master?

I would close and open one more new PR, and if that doesn't work, we'll just merge it

@laloch

laloch commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

@gforsyth, OK, let's do it.
Closing to reopen in yet another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected newlines in @$(...) substitution Captured subprocess syntax issue Syntax for *just* stripping last newline

3 participants