Fix keepalive timer logic#597
Merged
Merged
Conversation
- Reset timer on send instead of receive (pool needs to know we're alive) - Remove timer disable after first ping to enable continuous keepalives The previous implementation only sent one keepalive ping because m_keepAlive was set to 0 after ping(), disabling the timer. Also, resetting the timer on receive doesn't make sense - the pool needs to know the client is still alive, which requires activity from the client side, not just receiving data.
Owner
|
Merged into the Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset keepalive timer on send instead of receive - the pool needs to know the client is alive, not the other way around.
Also remove
m_keepAlive = 0inping()which was disabling the timer after the first ping, so only one keepalive would ever be sent.