Update assertj+tests work with other locales#180
Closed
asturio wants to merge 3 commits into
Closed
Conversation
- maven-assembly-plugin 3.0.0 -> 3.2.0 (bogus warning) - assert 2.9.0 -> 3.15.0
- Some Tests expect Messages in english, and running them on other locales won't work. So the test-classes set the locale to english before the tests and restore them after the tests
- as original code
Member
|
Many thanks @asturio . This module depends on AssertJ 2.x in order to be buildable with Java7 - see https://travis-ci.org/github/xmlunit/xmlunit/jobs/675025927. I don't think your changes really require us updating the dependency. Could you please revert that part? Also please add a license header to the new What you are doing with |
Member
|
After re-installing my OS I'm now facing the same problem :-) I've decided to take a slightly different approach, though. See c5f1899 Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies updated:
AssertJ Unittests run on other locales
won't work. So the test-classes set the locale to english before the tests
and restore them after the tests