Refactored the “always resolve” feature to avoid namespaces#231
Merged
ndw merged 1 commit intoxmlresolver:mainfrom Mar 13, 2025
Merged
Refactored the “always resolve” feature to avoid namespaces#231ndw merged 1 commit intoxmlresolver:mainfrom
ndw merged 1 commit intoxmlresolver:mainfrom
Conversation
Fix xmlresolver#229 There’s an unfortunate interaction between the ResolverFeature.ALWAYS_RESOLVE feature and namespace URI lookup. Using a namespace URI to find, for example, a schema in the catalog, or via indirection with RDDL to find things online, makes sense. But, generally speaking, what’s located at the namespace URI is not a useful resource. It’s very often not even present. This PR refactors how the “always resolve” feature is implemented so that it can be set on a per-request basis. By default, it’s the same as the global configuration setting, but when doing namespace URI lookup, we disable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #229
There’s an unfortunate interaction between the ResolverFeature.ALWAYS_RESOLVE feature and namespace URI lookup. Using a namespace URI to find, for example, a schema in the catalog, or via indirection with RDDL to find things online, makes sense. But, generally speaking, what’s located at the namespace URI is not a useful resource. It’s very often not even present.
This PR refactors how the “always resolve” feature is implemented so that it can be set on a per-request basis. By default, it’s the same as the global configuration setting, but when doing namespace URI lookup, we disable it.