fix: [0.8.x] update ownerDocument when moving nodes between documents#933
fix: [0.8.x] update ownerDocument when moving nodes between documents#933karfau merged 2 commits intoxmldom:release-0.8.xfrom
ownerDocument when moving nodes between documents#933Conversation
ownerDocument when moving nodes between documentsownerDocument when moving nodes between documents
|
Thank you for your continued contributions, especially the great test coverage. Do I understand correctly that this is an issue in 0.8.x and 0.9.x? But since you did it the other way around I took the opportunity to turn on GitHub checks for 0.8.x versions. |
|
PS: I have some other fixes to add to 0.8.x before doing another release. |
|
@karfau I did it for 0.8.x since that is what I am using. If you want I can also make a PR for the master with the same changes. |
|
@shunkica providing the same fix against master would be very much appriciated, thx. |
|
I have released 0.8.11 containing your fix, which was straight forward due to the outdated devDpendencies on that branch (previous release took place in Deember 2023). |
|
That is unfortunate. There is still an issue with importNode which I am still working on. |
|
Well now I got it working, the next one will be faster :) |
Resolves issue #932