fix: lower error level for unicode replacement character#794
Merged
Conversation
I was misled by some test cases from xmltest.zip, to think that xml containing the Unicode replacement character should be treated as not well-formed. This is now fixed by lowering the error level from `fatalError` which can not be ignored, to `warning` which can be ignored. It can also be treated as an exit condition by using `onWarningStopParsing` as the error handler, which is recommended if you do not need to be lax about the content being parsed. fixes #790
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/xmltest@2.0.1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=======================================
Coverage 95.05% 95.05%
=======================================
Files 8 8
Lines 2165 2165
Branches 569 569
=======================================
Hits 2058 2058
Misses 107 107 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was misled by some test cases from xmltest.zip,
to think that xml containing the Unicode replacement character should be treated as not well-formed. This is now fixed by lowering the error level from
fatalErrorwhich can not be ignored, towarningwhich can be ignored.It can also be treated as an exit condition by using
onWarningStopParsingas the error handler, which is recommended if you do not need to be lax about the content being parsed.fixes #790