refactor: merge redundant ']' condition at start of while loop#698
Merged
refactor: merge redundant ']' condition at start of while loop#698
Conversation
with the proposed fix `parseDoctypeInternalSubset` had two places that checked for the ending symbol and returned the internalSubSet string. By moving it to the beginning of the while loop, we only need to have it once. I also added tests for more cases ending with a space before the closing square bracket.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 94.28% 94.26% -0.02%
==========================================
Files 8 8
Lines 2100 2094 -6
Branches 538 537 -1
==========================================
- Hits 1980 1974 -6
Misses 120 120 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with the fix added in #692
parseDoctypeInternalSubsethas two places that check for the ending symbol and returned theinternalSubSetas a string. By moving it to the beginning of the while loop, we only need to check the condition once.I also added tests for more cases ending with a space before the closing square bracket.