feat: add iterator function to NodeList and NamedNodeMap#634
feat: add iterator function to NodeList and NamedNodeMap#634karfau merged 7 commits intoxmldom:masterfrom Ponynjaa:feature/633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
+ Coverage 93.89% 93.96% +0.06%
==========================================
Files 8 8
Lines 2048 2070 +22
Branches 532 536 +4
==========================================
+ Hits 1923 1945 +22
Misses 125 125 ☔ View full report in Codecov by Sentry. |
|
Can you please also add a test for these? |
|
There currently is a restriction to only use ES5 inside the lib folder. |
|
I added tests and rewrote the iterator to be ES5 compatible. As you can see it's way more code for the same thing but I guess it works... |
karfau
left a comment
There was a problem hiding this comment.
I think when prefixing the unused item variables, that eslint complains about in the tests with _ eslint should stop complaining.
Great job!
|
@karfau done 😉 |
Closes #633