fix: avoid prototype clash in namespace prefix#554
Merged
Conversation
by completely avoiding Object literals. - Always use `Object.create(null)` - `freeze` now creates a copy of the passed object without a prototype - added `hasOwn` that mimics `Object.hasOwn` (not part of ES5) - add ESLint rule `no-prototype-builtins` to get feedback as early as possible
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
==========================================
+ Coverage 93.88% 93.89% +0.01%
==========================================
Files 8 8
Lines 2044 2048 +4
Branches 531 532 +1
==========================================
+ Hits 1919 1923 +4
Misses 125 125
☔ View full report in Codecov by Sentry. |
This was referenced Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by completely avoiding Object literals.
Object.create(null)freezenow creates a copy of the passed object without a prototypehasOwnthat mimicsObject.hasOwn(not part of ES5)no-prototype-builtinsto get feedback as early as possible