Skip to content

Rename udefines to undefines#4

Merged
waruqi merged 1 commit intoxmake-io:masterfrom
daviwil:fix-undefines
Apr 6, 2023
Merged

Rename udefines to undefines#4
waruqi merged 1 commit intoxmake-io:masterfrom
daviwil:fix-undefines

Conversation

@daviwil
Copy link
Copy Markdown
Contributor

@daviwil daviwil commented Apr 6, 2023

It appears that add_undefines was implemented as add_udefines and the words udefines and undefines were causing a conflict in the code which made CI fail for PR #3. This PR fixes the naming issue and adds an example usage of add_undefines to make sure it can be executed correctly.

@waruqi waruqi merged commit 7122388 into xmake-io:master Apr 6, 2023
@waruqi
Copy link
Copy Markdown
Member

waruqi commented Apr 6, 2023

thanks

@daviwil daviwil deleted the fix-undefines branch April 6, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants