Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where shared libraries built with the Zig toolchain on Windows platforms failed to link correctly. The change introduces the necessary system libraries as shared library linker flags, enabling successful compilation and linking of Zig-based shared libraries on Windows. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| if toolchain:is_plat("windows") then | ||
| toolchain:add("zcldflags", "--subsystem console") | ||
| toolchain:add("zcldflags", "-lkernel32", "-lntdll") | ||
| toolchain:add("zcshflags", "-lc", "-lkernel32", "-lntdll") |
There was a problem hiding this comment.
The libraries -lkernel32 and -lntdll are also used for zcldflags on the line above. Consider defining them in a local variable to avoid duplication and improve maintainability.
#7389