fix install script incompatibility with coreutils 9.10#7386
fix install script incompatibility with coreutils 9.10#7386waruqi merged 1 commit intoxmake-io:devfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility issue within the build script, ensuring its continued functionality after a recent update to GNU Coreutils. By adjusting a command-line argument, the change prevents build failures and maintains robust operation across different system environments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request fixes an incompatibility with coreutils 9.10 by changing tail -c 7 to tail -c7. While this is a valid fix for the immediate issue, the method of extracting the version number is fragile and will break when tag names change length (e.g., from v1.2.3 to v1.10.0). I've suggested a more robust way to extract the latest version tag that doesn't rely on a fixed character count.
| cp -r . $projectdir | ||
| elif test_eq "$branch" "__run__"; then | ||
| version=$(git ls-remote --tags "$gitrepo" | tail -c 7) | ||
| version=$(git ls-remote --tags "$gitrepo" | tail -c7) |
There was a problem hiding this comment.
While your change fixes the immediate issue with coreutils 9.10, the method of extracting the version number is fragile. It relies on the tag name being a fixed length. For example, if the version changes from v2.9.9 to v2.10.0, the tag length will change, and tail -c7 will extract an incorrect version string.
A more robust approach would be to sort the tags as versions and extract the last part of the ref:
version=$(git ls-remote --tags --sort='v:refname' "$gitrepo" | tail -n 1 | sed 's|.*/||')This ensures you always get the latest version tag regardless of its length.
| version=$(git ls-remote --tags "$gitrepo" | tail -c7) | |
| version=$(git ls-remote --tags --sort='v:refname' "$gitrepo" | tail -n 1 | sed 's|.*/||') |
The newest version of GNU Coreutils (9.10) changed the cli parser. In the shell install script, the space in
tail -c 7results in an error:tail: cannot open '7' for reading.Changing totail -c7makes the error go away on 9.10 and works in older versions as well.