Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the packaging capabilities of the system by introducing new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for tarxz and srctarxz packaging formats and improves the existing targz implementation. While the changes enhance handling of tar, gzip, and 7z archivers, a high-severity argument injection vulnerability was identified in the tar archiving logic, potentially leading to arbitrary command execution via malicious exclude patterns. Furthermore, a logic bug in gzip and xz archiving functions incorrectly passes the output archive file as an input argument. For improved maintainability, consider refactoring a series of if statements into a lookup table.
|
|
||
| -- archive it | ||
| os.vrunv(tar.program, argv, {curdir = opt.curdir}) | ||
| os.vrunv(program, argv, {curdir = opt.curdir}) |
There was a problem hiding this comment.
The tar command is executed with arguments that include user-supplied exclude patterns. Because the --exclude= flag and the pattern are passed as separate arguments (at lines 296-297), tar will interpret any pattern starting with a hyphen as a new command-line option. An attacker could provide a malicious pattern like --checkpoint-action=exec=id to achieve arbitrary command execution when xmake pack is run.
To remediate this, combine the flag and the pattern into a single argument: table.insert(argv, "--exclude=" .. exclude).
|
Can we have .conda? |
#7361