Skip to content

Supports custom templates#7360

Merged
waruqi merged 12 commits intodevfrom
template
Mar 2, 2026
Merged

Supports custom templates#7360
waruqi merged 12 commits intodevfrom
template

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Feb 28, 2026 •
edited
Loading

@waruqi waruqi added this to the v3.0.8 milestone Feb 28, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 28, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant architectural improvement to Xmake's project creation functionality. By refactoring template-related logic into a new, centralized template module, the system becomes more modular and maintainable. The changes also streamline the template file structure and enhance the command-line interface for creating projects, while removing outdated Tbox-specific templates.

Highlights

  • Template System Refactor: The core logic for project template creation has been extracted from xmake/actions/create/main.lua into a new, dedicated module xmake/actions/create/template.lua to improve modularity and maintainability.
  • Simplified Template Structure: The project subdirectory within many templates (e.g., xmake/templates/c++/console/project/src/main.cpp to xmake/templates/c++/console/src/main.cpp) has been removed, flattening the template file hierarchy across all languages.
  • Removal of template.lua files: All individual template.lua definition files within template directories have been removed, indicating a shift to a convention-based template discovery and configuration.
  • Tbox Template Deprecation: All Tbox-related project templates for both C and C++ have been entirely removed from the system.
  • Enhanced Command-line Options: The xmake create command's --language and --template options now dynamically fetch available languages and templates using the new module, improving user experience and command-line completion.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • xmake/actions/create/main.lua
    • Refactored project creation logic and removed deprecated template ID handling.
  • xmake/actions/create/template.lua
    • Added a new module for centralized template management, including functions for discovering templates, copying files, and replacing variables.
  • xmake/actions/create/xmake.lua
    • Updated the create task's command-line options to dynamically list available languages and templates.
  • xmake/core/project/template.lua
    • Removed, as its functionality was moved to xmake/actions/create/template.lua.
  • xmake/core/sandbox/modules/import/core/project/template.lua
    • Removed due to the removal of its underlying dependency.
  • xmake/templates///project/...
    • Renamed project subdirectories to flatten the template structure, moving contents up one level for all affected templates.
  • xmake/templates///template.lua
    • Removed all individual template definition files across various languages and templates.
  • xmake/templates/c++/tbox.*
    • Removed all Tbox-related C++ template files, including source code and build configurations.
  • xmake/templates/c/tbox.*
    • Removed all Tbox-related C template files, including source code and build configurations.
    • Using Gemini Code Assist

    The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

    Invoking Gemini

    You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

    Feature Command Description
    Code Review /gemini review Performs a code review for the current pull request in its current state.
    Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
    Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
    Help /gemini help Displays a list of available commands.

    Customization

    To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

    Limitations & Feedback

    Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

    You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

    Footnotes

    1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 28, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly refactors the project template creation system, moving logic to a dedicated actions.create.template module and simplifying template structure for improved maintainability. However, it introduces several security vulnerabilities, including path traversal in template discovery and project creation, and a command injection vulnerability leading to Remote Code Execution (RCE) via xmake.lua due to improper handling of user-supplied input. Additionally, there are suggestions for improving edge case handling, such as ensuring case-insensitivity for xmake.lua detection and refining shell completion. It is critical to address these security concerns by implementing strict validation and sanitization for all user-controlled parameters, especially those used in file path construction and template variable substitution.

@waruqi waruqi changed the title Improve templates Supports custom templates and remote distribution Feb 28, 2026
@waruqi waruqi changed the title Supports custom templates and remote distribution Supports custom templates Mar 2, 2026
@waruqi waruqi merged commit 4662898 into dev Mar 2, 2026
58 checks passed
This was referenced Mar 2, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.8

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi