Skip to content

Try fixing issue #7354#7356

Merged
waruqi merged 2 commits intoxmake-io:devfrom
luadebug:bin
Feb 26, 2026
Merged

Try fixing issue #7354#7356
waruqi merged 2 commits intoxmake-io:devfrom
luadebug:bin

Conversation

@luadebug
Copy link
Member

@luadebug luadebug commented Feb 26, 2026 •
edited
Loading

Resolves: #7354

@luadebug luadebug mentioned this pull request Feb 26, 2026
Closed
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 26, 2026

Summary of Changes

Hello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to resolve a potential issue, likely related to issue #7354, by enhancing the reliability of dependency file handling within the build system. The core change involves streamlining the collection of dependency files and, crucially, enforcing a consistent sort order for these files. This ensures that the build process is more deterministic and less prone to inconsistencies caused by varying file order.

Highlights

  • Dependency File Handling Refinement: Simplified the logic for collecting dependency files (depfiles) within the get_linkdepfiles function, making the code more concise.
  • Deterministic Build Output: Introduced table.sort(depfiles) to ensure that the collected dependency files are always processed in a consistent, sorted order, which helps in achieving deterministic builds and preventing order-related issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • xmake/modules/private/action/build/target.lua
    • Simplified the conditional logic for combining object files and extra files into the depfiles list.
    • Added table.sort(depfiles) to guarantee a deterministic order for all linked dependency files.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 26, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue by sorting the dependency files for linking, which is a good practice to ensure reproducible builds. The code is also simplified by removing a conditional check, which makes it cleaner and safer by preventing potential modification of a cached internal table. The changes appear correct and beneficial.

@waruqi waruqi mentioned this pull request Feb 26, 2026
Closed
@waruqi waruqi added this to the v3.0.8 milestone Feb 26, 2026
@waruqi waruqi mentioned this pull request Feb 26, 2026
Closed
@MaxwellGengYF
Copy link
Contributor

MaxwellGengYF commented Feb 26, 2026

测了一下，这个没问题了。

@Issues-translate-bot
Copy link

Issues-translate-bot commented Feb 26, 2026

Bot detected the issue body's language is not English, translate it automatically.

I tested it, and it's no problem.

@waruqi waruqi closed this Feb 26, 2026
@waruqi waruqi reopened this Feb 26, 2026
@waruqi waruqi merged commit 07ece4e into xmake-io:dev Feb 26, 2026
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.8

Development

Successfully merging this pull request may close these issues.

bin2obj 会错误的触发link

4 participants

@luadebug @MaxwellGengYF @Issues-translate-bot @waruqi