do not fix the JDK version in the swig rules#7352
Conversation
Summary of ChangesHello @binLep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求解决了 SWIG 规则中与 Java 开发工具包 (JDK) 版本兼容性相关的构建问题。它从 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
可以按照 genmini 说的，加个 java version 的指定参数。。有时候一些 java 模块可能需要限定 java 版本。 |
You can follow what genmini said and add a java version specified parameter. . Sometimes some java modules may need to limit the java version. |
我先把这个 release 版本的问题交了
这里固定了 jdk 版本为 17，用 jdk 1.8 的话会报错，删了就好了